Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AWS Auth manager user output #42454

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Refactor AWS Auth manager user output #42454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions airflow/providers/amazon/aws/auth_manager/cli/idc_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from __future__ import annotations

import logging
import sys
from typing import TYPE_CHECKING

import boto3
Expand Down Expand Up @@ -139,10 +140,13 @@ def _create_application(client: BaseClient, instance_arn: str | None, args) -> s
# Remove this part when it is supported
if "is not supported for this action" in e.response["Error"]["Message"]:
print(
"Creation of SAML applications is only supported in AWS console today. "
"Please create the application through the console."
"*************************************************************************\n"
"* ACTION REQUIRED *\n"
"* Creation of SAML applications is only supported in AWS console today. *\n"
"* Please create the application through the console. *\n"
"*************************************************************************\n"
)
raise
sys.exit(1)

print(f"Application created: '{response['ApplicationArn']}'")

Expand Down
6 changes: 1 addition & 5 deletions docs/apache-airflow-providers-amazon/auth-manager/setup/identity-center.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,7 @@ To create the resources, please run the following command:

airflow aws-auth-manager init-identity-center

The CLI command should exit successfully with the message: ::

AWS IAM Identity Center resources created successfully.

If the CLI command exited with an error, please look carefully at the CLI command output to understand which resource(s)
The CLI command will ask you to create any resources manually if they cannot be automatically created. Please look carefully at the CLI command output to understand which resource(s)
have or have not been created successfully. The resource(s) which have not been successfully created need to be
:ref:`created manually <identity_center_manual_configuration>`.

Expand Down