Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure DAG trigger form submits with updated parameters upon key… #42487

Merged

Conversation

dannyl1u
Copy link
Contributor

closes: #42157
Fixes bug where pressing "enter" on the keyboard submitted the DAG trigger form without updated values.
Fixed by making a call to the existing updateJSONconf() function onsubmit


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 26, 2024
Copy link

boring-cyborg bot commented Sep 26, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, working as expected

@pierrejeambrun pierrejeambrun merged commit 5af7463 into apache:main Sep 26, 2024
53 checks passed
Copy link

boring-cyborg bot commented Sep 26, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Sep 26, 2024
pierrejeambrun added a commit that referenced this pull request Sep 26, 2024
…board submit (#42487) (#42499)

(cherry picked from commit 5af7463)

Co-authored-by: Danny Liu <dannyjialiliu@gmail.com>
@jscheffl
Copy link
Contributor

Thanke for the PR. Just coming "late to the party". So the described bug is fixed but another feature that (we at least) often use is now broken:
If the form is submitted then the "Generated Config JSON" is ALWAYS updated. We often use this to copy&paste previous or generated data to save the effort to manually copy&paste all individual fields. But now if I copy&Paste or change in the JSON field, upon submit() the changes are over-ridden with the "default text" from the form (and so far known gap, individual fields are not updated if the JSON is changed.
image

@dannyl1u
Copy link
Contributor Author

@jscheffl sorry about that, looking into it!

@jscheffl
Copy link
Contributor

@jscheffl sorry about that, looking into it!

I'm also lookin ginto this and am in the hell ... complexity of JavaScript and events and what fires when :-(

@dannyl1u dannyl1u deleted the fix/dag-trigger-form-keyboard-submit branch September 30, 2024 18:44
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
…board submit (#42487) (#42499)

(cherry picked from commit 5af7463)

Co-authored-by: Danny Liu <dannyjialiliu@gmail.com>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
…board submit (#42487) (#42499)

(cherry picked from commit 5af7463)

Co-authored-by: Danny Liu <dannyjialiliu@gmail.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Dag trigger form not submitting parameters on keyboard submit
4 participants