-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure DAG trigger form submits with updated parameters upon key… #42487
fix: ensure DAG trigger form submits with updated parameters upon key… #42487
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, working as expected
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…board submit (apache#42487) (cherry picked from commit 5af7463)
@jscheffl sorry about that, looking into it! |
I'm also lookin ginto this and am in the |
closes: #42157
Fixes bug where pressing "enter" on the keyboard submitted the DAG trigger form without updated values.
Fixed by making a call to the existing
updateJSONconf()
functiononsubmit
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.