-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to provide proxy for dbt Cloud connection #42737
Add ability to provide proxy for dbt Cloud connection #42737
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Needs unit tests. |
Happy to add some, but I am not able run the existing ones. Hence why I was wondering if there was any pointer or guidance. If I do a |
I actually managed to run the tests with I have updated them so that they pass again and I have added an extra test with the proxy. Let me know if instead of creating a new test you prefer if I update all the My rationale for adding a new test for the proxy rather than as a parameter for all tests is that most people using the providers won't need the proxy. |
6f024f7
to
c5afd71
Compare
BTW. Re venv - you should be able to run the test in venv created with `pip install -e ".[dbt.cloud,devel-tests]" - that should install all what is needed to run the tests. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Just simplified redundant code from apache#42737
Just simplified redundant code from #42737
* Add ability to provide proxy for dbt Cloud connection * Running pre-commit checks * Update current tests and add new test with proxy
Just simplified redundant code from apache#42737
* Add ability to provide proxy for dbt Cloud connection * Running pre-commit checks * Update current tests and add new test with proxy
Just simplified redundant code from apache#42737
Just simplified redundant code from apache#42737
* Add ability to provide proxy for dbt Cloud connection * Running pre-commit checks * Update current tests and add new test with proxy
Just simplified redundant code from apache#42737
* Add ability to provide proxy for dbt Cloud connection * Running pre-commit checks * Update current tests and add new test with proxy
Just simplified redundant code from apache#42737
* Add ability to provide proxy for dbt Cloud connection * Running pre-commit checks * Update current tests and add new test with proxy
Just simplified redundant code from apache#42737
Adding the ability to define proxy settings when connecting to dbt Cloud. This can be useful for people setting up IP restrictions on dbt Cloud, allowing only some IPs to connect.
This is my first contribution to Airflow, so feel free to let me know if I need to do anything else.
I update the code for the hooks and added some documentation.
I didn't add tests as I am not too sure of how I could do it in that case, but I am happy to do so with a bit of pointers/guidance.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.