Skip to content

Commit

Permalink
Simplify code for recent dbt provider change (apache#42840)
Browse files Browse the repository at this point in the history
Just simplified redundant code from apache#42737
  • Loading branch information
kaxil authored and ellisms committed Nov 13, 2024
1 parent b4900de commit 1f4892c
Showing 1 changed file with 11 additions and 19 deletions.
30 changes: 11 additions & 19 deletions airflow/providers/dbt/cloud/hooks/dbt.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,26 +244,18 @@ async def get_job_details(
endpoint = f"{account_id}/runs/{run_id}/"
headers, tenant = await self.get_headers_tenants_from_connection()
url, params = self.get_request_url_params(tenant, endpoint, include_related)
proxies = self._get_proxies(self.connection)
proxies = self._get_proxies(self.connection) or {}

async with aiohttp.ClientSession(headers=headers) as session:
if proxies is not None:
if url.startswith("https"):
proxy = proxies.get("https")
else:
proxy = proxies.get("http")
async with session.get(url, params=params, proxy=proxy) as response:
try:
response.raise_for_status()
return await response.json()
except aiohttp.ClientResponseError as e:
raise AirflowException(f"{e.status}:{e.message}")
else:
async with session.get(url, params=params) as response:
try:
response.raise_for_status()
return await response.json()
except aiohttp.ClientResponseError as e:
raise AirflowException(f"{e.status}:{e.message}")
proxy = proxies.get("https") if proxies and url.startswith("https") else proxies.get("http")
extra_request_args = {}

if proxy:
extra_request_args["proxy"] = proxy

async with session.get(url, params=params, **extra_request_args) as response: # type: ignore[arg-type]
response.raise_for_status()
return await response.json()

async def get_job_status(
self, run_id: int, account_id: int | None = None, include_related: list[str] | None = None
Expand Down

0 comments on commit 1f4892c

Please sign in to comment.