feat: Add authorization params to openid-connect plugin #10058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorSmith-msr
changed the title
Revolyssup
requested changes
Aug 21, 2023
Revolyssup
added
the
wait for update
Revolyssup
removed
the
wait for update
| }, | ||
| authorization_params = { | ||
| description = "Extra authorization params to the authorize endpoint", | ||
| type = "object" |
There was a problem hiding this comment.
Could you add test cases for this option?
There was a problem hiding this comment.
Yep, I'm working on learning the testing framework now.
There was a problem hiding this comment.
You can refer to these test cases: https://github.com/apache/apisix/blob/master/t/plugin/openid-connect.t
monkeyDluffy6017
added
the
wait for update
|
@TrevorSmith-msr thanks for this PR, it will be great if you can add some test cases for it. |
|
Hey @moonming, thanks for commenting. I've been having trouble getting my environment working for tests and as a result haven't been prioritizing this very highly. I think it would be great to get some help at some point. |
|
@TrevorSmith-msr Maybe if you give me write permissions on this branch, I can help you out with tests. :) |
|
@Revolyssup please make the ci pass |
|
@monkeyDluffy6017 done |
Sn0rt
reviewed
Oct 23, 2023
| @@ -67,6 +67,7 @@ description: OpenID Connect allows the client to obtain user information from th | |||
| | proxy_opts.http_proxy_authorization | string | False | | Basic [base64 username:password] | Default `Proxy-Authorization` header value to be used with `http_proxy`. | | |||
| | proxy_opts.https_proxy_authorization | string | False | | Basic [base64 username:password] | As `http_proxy_authorization` but for use with `https_proxy` (since with HTTPS the authorisation is done when connecting, this one cannot be overridden by passing the `Proxy-Authorization` request header). | | |||
| | proxy_opts.no_proxy | string | False | | | Comma separated list of hosts that should not be proxied. | | |||
| | authorization_params | object | False | | | Additional parameters to send in the in the request to the authorization endpoint. | | |||
Sn0rt
approved these changes
Oct 23, 2023
Signed-off-by: Ashish Tiwari <ashishjaitiwari15112000@gmail.com>
Sn0rt
approved these changes
Oct 23, 2023
monkeyDluffy6017
approved these changes
Oct 23, 2023
|
@Revolyssup Good job! |
monkeyDluffy6017
added
approved
and removed
wait for update
Revolyssup
approved these changes
Oct 23, 2023
|
Thank you @Revolyssup and @Sn0rt for your help finishing this up. |
hongbinhsu
pushed a commit
to fitphp/apix
that referenced
this pull request
Nov 1, 2023
* upstream/master: (83 commits) fix: make install failed on mac (apache#10403) feat(zipkin): add variable (apache#10361) test(clickhouse-logger): to show that different endpoints will be chosen randomly (apache#8777) chore(deps): bump actions/setup-node from 3.8.1 to 4.0.0 (apache#10381) ci: fix the grpc test error (apache#10388) ci: trigger ci when doc-lint.yml changes (apache#10382) docs: fix usage of incorrect default admin api port (apache#10391) feat: Add authorization params to openid-connect plugin (apache#10058) feat: integrate authz-keycloak with secrets resource (apache#10353) fix(traffic-split): post_arg match fails because content-type contains charset (apache#10372) fix(consul): worker will not exit while reload or quit (apache#10342) chore: update rules for unresponded issues (apache#10354) docs: Update APISIX usecases in README (apache#10358) test: use http2 to test limit-req plugin (apache#10334) test: use http2 to test limit-conn plugin (apache#10332) chore: remove stream_proxy.only in config-default.yaml (apache#10337) docs: update underscore to hyphen in HTTP headers in `response-rewrite` plugin (apache#10347) fix: typos in comments (apache#10330) feat: support config stream_route upstream in service (apache#10298) fix: keep healthcheck target state when upstream changes (apache#10312) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to configure additional authorization params included in the openid-connect plugin.
Fixes #10057
Checklist
If tests are required, I may need assistance in writing those.