Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the grpc test error #10388

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

xuruidong
Copy link
Contributor

Description

Fixes #9417

There are many failed CI tests due to the grpc test.
https://github.com/apache/apisix/actions/runs/6555753481/job/17804672395
https://github.com/apache/apisix/actions/runs/6505891288/job/17670381622
https://github.com/apache/apisix/actions/runs/6505891281/job/17670380923
image

apisix get 502 from upstream:
image

The reason is that the grpc-server-example start failed due to port occupancy.
image

I thought maybe some client sockets occupied on the port and I reproduced the issue.
The test use docker container with host network mode and I did not find a way to set net.ipv4.ip_local_reserved_ports in github action.
The default net.ipv4.ip_local_port_range is 32768-60999, so use the port not in range 32768-60999 to avoid port occupancy.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@xuruidong xuruidong marked this pull request as draft October 24, 2023 13:03
@xuruidong xuruidong marked this pull request as ready for review October 24, 2023 14:08
@xuruidong xuruidong marked this pull request as draft October 24, 2023 14:10
@xuruidong xuruidong marked this pull request as ready for review October 24, 2023 14:19
@shreemaan-abhishek
Copy link
Contributor

thank you for your contribution 🙏🏼

@monkeyDluffy6017
Copy link
Contributor

Great job!

@monkeyDluffy6017 monkeyDluffy6017 merged commit fc39dd8 into apache:master Oct 25, 2023
31 checks passed
@xuruidong xuruidong deleted the fix-grpc-test branch October 25, 2023 09:42
hongbinhsu pushed a commit to fitphp/apix that referenced this pull request Nov 1, 2023
* upstream/master: (83 commits)
  fix: make install failed on mac (apache#10403)
  feat(zipkin): add variable (apache#10361)
  test(clickhouse-logger): to show that different endpoints will be chosen randomly (apache#8777)
  chore(deps): bump actions/setup-node from 3.8.1 to 4.0.0 (apache#10381)
  ci: fix the grpc test error (apache#10388)
  ci: trigger ci when doc-lint.yml changes (apache#10382)
  docs: fix usage of incorrect default admin api port (apache#10391)
  feat: Add authorization params to openid-connect plugin (apache#10058)
  feat: integrate authz-keycloak with secrets resource (apache#10353)
  fix(traffic-split): post_arg match fails because content-type contains charset (apache#10372)
  fix(consul): worker will not exit while reload or quit (apache#10342)
  chore: update rules for unresponded issues (apache#10354)
  docs: Update APISIX usecases in README (apache#10358)
  test: use http2 to test limit-req plugin (apache#10334)
  test: use http2 to test limit-conn plugin (apache#10332)
  chore: remove stream_proxy.only in config-default.yaml (apache#10337)
  docs: update underscore to hyphen in HTTP headers in `response-rewrite` plugin (apache#10347)
  fix: typos in comments (apache#10330)
  feat: support config stream_route upstream in service (apache#10298)
  fix: keep healthcheck target state when upstream changes (apache#10312)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: the CI is unstable
3 participants