-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add 'take' bot like main Arrow repo #1500
Conversation
Tested here: soumyadsanyal#3 (comment) . |
For this optional behavior: was there an existing flow (in a different repo?) implementing this that you had in mind? |
I think we can ignore that. However, would you mind adding this to CONTRIBUTING.md? I would say under "Opening a Pull Request", we can say (1) please check if there is an issue or make one, (2) assign the issue to yourself by commenting "take" |
Yes, sounds good. I've pushed the change. I think it might also be nice to, once this is in
How does that sound? |
That sounds good to me, thank you! |
…e to corresponding issue as 'Closes #NNNN'. Co-authored-by: David Li <li.davidm96@gmail.com>
Perfect! I'll add a follow-up issue and PR once this is in Separately, I committed your suggestion around cross-referencing the corresponding issue in the PR. As a follow up question to that, is it worth it to add a template in |
Yeah, we should set that up eventually. |
Resolves #1347 .