Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add 'take' bot like main Arrow repo #1500

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

soumyadsanyal
Copy link
Contributor

Resolves #1347 .

@soumyadsanyal
Copy link
Contributor Author

Tested here: soumyadsanyal#3 (comment) .

@soumyadsanyal
Copy link
Contributor Author

@lidavidm

Also, possibly have a bot edit in or comment to make it clear how this works to people landing in the repo

For this optional behavior: was there an existing flow (in a different repo?) implementing this that you had in mind?

@lidavidm
Copy link
Member

@lidavidm

Also, possibly have a bot edit in or comment to make it clear how this works to people landing in the repo

For this optional behavior: was there an existing flow (in a different repo?) implementing this that you had in mind?

I think we can ignore that.

However, would you mind adding this to CONTRIBUTING.md? I would say under "Opening a Pull Request", we can say (1) please check if there is an issue or make one, (2) assign the issue to yourself by commenting "take"

@soumyadsanyal
Copy link
Contributor Author

soumyadsanyal commented Jan 31, 2024

@lidavidm

Also, possibly have a bot edit in or comment to make it clear how this works to people landing in the repo

For this optional behavior: was there an existing flow (in a different repo?) implementing this that you had in mind?

I think we can ignore that.

However, would you mind adding this to CONTRIBUTING.md? I would say under "Opening a Pull Request", we can say (1) please check if there is an issue or make one, (2) assign the issue to yourself by commenting "take"

Yes, sounds good. I've pushed the change.

I think it might also be nice to, once this is in main:

  1. demonstrate this flow with an example or future issue in this repo, and
  2. update CONTRIBUTING.md with that example, by linking to that "take" comment (as I did here).

How does that sound?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@lidavidm
Copy link
Member

That sounds good to me, thank you!

…e to corresponding issue as 'Closes #NNNN'.

Co-authored-by: David Li <li.davidm96@gmail.com>
@soumyadsanyal
Copy link
Contributor Author

That sounds good to me, thank you!

Perfect! I'll add a follow-up issue and PR once this is in main. (That issue will itself recursively solve for this, which makes it nice and self-contained.)

Separately, I committed your suggestion around cross-referencing the corresponding issue in the PR. As a follow up question to that, is it worth it to add a template in .github/pull_request_template.md and include that prompt there?

@lidavidm
Copy link
Member

Yeah, we should set that up eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: add 'take' bot like main Arrow repo
2 participants