Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update CONTRIBUTING.md with an example of self-assigning an issue. #1506

Merged
merged 2 commits into from
Feb 1, 2024
Merged

docs: update CONTRIBUTING.md with an example of self-assigning an issue. #1506

merged 2 commits into from
Feb 1, 2024

Conversation

soumyadsanyal
Copy link
Contributor

@soumyadsanyal soumyadsanyal commented Feb 1, 2024 •
edited by lidavidm
Loading

Closes #1505.

@github-actions github-actions bot added this to the ADBC Libraries 0.10.0 milestone Feb 1, 2024
@soumyadsanyal
Copy link
Contributor Author

soumyadsanyal commented Feb 1, 2024 •
edited
Loading

(Tagging @lidavidm for review as a follow up to this discussion.)

lidavidm
lidavidm approved these changes Feb 1, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@soumyadsanyal @lidavidm
docs: add whitespace
93a86fd 
Co-authored-by: David Li <li.davidm96@gmail.com>
@soumyadsanyal
Copy link
Contributor Author

soumyadsanyal commented Feb 1, 2024 •
edited
Loading

@lidavidm

Thanks for the review (and suggestion)!

lidavidm
lidavidm approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit 1d7dbfe into apache:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.10.0
Development

Successfully merging this pull request may close these issues.

docs: update CONTRIBUTING.md with an example of self-assigning an issue
2 participants
@soumyadsanyal @lidavidm