fix clippy warnings #581
fix clippy warnings #581
Conversation
| @@ -248,12 +248,14 @@ where | |||
| } | |||
|
|
|||
| impl ToDFSchema for Schema { | |||
| #[allow(clippy::wrong_self_convention)] | |||
There was a problem hiding this comment.
maybe it's a better idea to remove https://github.com/apache/arrow-datafusion/pull/581/files#diff-54ef5cfee73dd6cdbd9186bbf5931f4e375ccf002f956d1fe8bf35deafaf56a6R244
There was a problem hiding this comment.
I don't understand the suggestion
jimexist
force-pushed
the
fix-clippy-warnings
branch
3 times, most recently
from
d1c79cf
to
2dfb81e
Compare
jimexist
force-pushed
the
fix-clippy-warnings
branch
2 times, most recently
from
03b645c
to
3bd136c
Compare
jimexist
force-pushed
the
fix-clippy-warnings
branch
from
3bd136c
to
0b1905e
Compare
jimexist
force-pushed
the
fix-clippy-warnings
branch
from
2ff3716
to
5a0f93d
Compare
|
Maybe for the moment it is wise to temporarily disable coverage task in CI? |
|
Not sure what the coverage failure was: https://github.com/apache/arrow-datafusion/pull/581/checks?check_run_id=2858343109 I restarted the tests |
| @@ -248,12 +248,14 @@ where | |||
| } | |||
|
|
|||
| impl ToDFSchema for Schema { | |||
| #[allow(clippy::wrong_self_convention)] | |||
There was a problem hiding this comment.
I don't understand the suggestion
.github/workflows/rust.yml
Outdated
| # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0 | ||
| # see https://github.com/xd009642/tarpaulin/issues/618 | ||
| cargo install --version 0.16.0 cargo-tarpaulin | ||
| cargo install --version 0.18.0-alpha3 cargo-tarpaulin |
There was a problem hiding this comment.
I don't understand this change. It seems to cause an error in CI, right?: https://github.com/apache/arrow-datafusion/pull/581/checks?check_run_id=2858343109
Maybe we could put the old version of tarpaulin back?
There was a problem hiding this comment.
It was failing either way so this line diff was my attempt to fix it in vain
There was a problem hiding this comment.
I see -- in that case it does seem like disabling code coverage until it is fixed is the right thing to do, and we can file an issue to re-enable it once whatever underlying issue is fixed
There was a problem hiding this comment.
Filed #590 to fix code coverage job. Will disable it via this PR
I tried several times and the error persists - not sure why given the fixture is now raw string so escaping should be out of picture |
|
Thanks again @jimexist |
Which issue does this PR close?
Closes #583
Closes #582
Rationale for this change
newest clippy will generate additional warnings on master
What changes are included in this PR?
Are there any user-facing changes?