Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude "TestFhirIO.*" from Go PostCommit Dataflow ARM test suite #28215

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

celeste-zeng
Copy link
Contributor

  • When the user is github-actions, exclude the test.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the go label Aug 29, 2023
@celeste-zeng
Copy link
Contributor Author

Run Go PostCommit Dataflow ARM

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@celeste-zeng
Copy link
Contributor Author

Run Go PostCommit Dataflow ARM

@celeste-zeng
Copy link
Contributor Author

Run Go PostCommit Dataflow ARM

@celeste-zeng celeste-zeng changed the title [Do not review yet] Exclude "TestFhirIO.*" from Go PostCommit Dataflow ARM test suite Exclude "TestFhirIO.*" from Go PostCommit Dataflow ARM test suite Aug 30, 2023
@riteshghorse
Copy link
Contributor

Run Go PostCommit

@riteshghorse
Copy link
Contributor

Run Go PostCommit Dataflow ARM

@riteshghorse
Copy link
Contributor

Looks like it had passed already but didn't show up here! https://github.com/apache/beam/actions/runs/6019820635

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@riteshghorse riteshghorse merged commit d616fc2 into apache:master Aug 30, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants