Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude "TestFhirIO.*" from Go PostCommit Dataflow ARM test suite #28215

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Exclude "TestFhirIO.*" from Go PostCommit Dataflow ARM test suite #28215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
909085e
Update integration.go to exclude one failed test
celeste-zeng Aug 29, 2023
2c13653
fix go syntax
celeste-zeng Aug 30, 2023
7267cb8
Fix usage of append
celeste-zeng Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sdks/go/test/integration/integration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import (
"strings"
"testing"
"time"
"os"

// common runner flag.
"github.com/apache/beam/sdks/v2/go/pkg/beam/options/jobopts"
Expand Down Expand Up @@ -301,6 +302,12 @@ func CheckFilters(t *testing.T) {
panic("ptest.Main() has not been called: please override TestMain to ensure that the integration test runs properly.")
}

var user = os.Getenv("USER")
// TODO: github-actions service account doesn't have permission to healthcare.fhirStores.create.
if user == "github-actions" {
dataflowFilters = append(dataflowFilters, "TestFhirIO.*")
}

// Check for sickbaying first.
n := t.Name()
for _, f := range sickbay {
Expand All @@ -318,7 +325,7 @@ func CheckFilters(t *testing.T) {
s1 := rand.NewSource(time.Now().UnixNano())
r1 := rand.New(s1)
*jobopts.JobName = fmt.Sprintf("go-%v-%v", strings.ToLower(n), r1.Intn(1000))

// Test for runner-specific skipping second.
var filters []string
runner := *ptest.Runner
Expand Down