-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test code to overwrite SQL in Beam Python JDBC #30417
Add test code to overwrite SQL in Beam Python JDBC #30417
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
ed2b26a
to
1a12a43
Compare
dea70be
to
2b1f5e8
Compare
From Python Lint precommit:
please fix |
f555e8c
to
bbb6c2b
Compare
Hi @jrmccluskey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test failed:
|
* Add python jdbc test with override query * fix jdbcio it test lint
)" (apache#30535) This reverts commit 2b8a737.
Please add a meaningful description for your change here
Add a test to overwrite SQL in Python JDBC. Previously(when I checked 2022-01-04), there was a bug where queries were not being overwritten, but upon checking now, it has been improved.I add the test code to overwrite SQL to close the related issue.
fixes #20446
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.