Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add test code to overwrite SQL in Beam Python JDBC (#30417)" #30535

Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Mar 6, 2024

This reverts commit 2b8a737.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Mar 6, 2024

Test failed:

test_xlang_jdbc_write_read_1_mysql (apache_beam.io.external.xlang_jdbcio_it_test.CrossLanguageJdbcIOTest) failed
sdks/python/pytest_postCommitIT-flink-py310.xml [took 57s]

ValueError: Type names and field names must be valid identifiers: 'count(*)'
a = (<apache_beam.io.external.xlang_jdbcio_it_test.CrossLanguageJdbcIOTest testMethod=test_xlang_jdbc_write_read_1_mysql>,)
kw = {}

    @wraps(func)
    def standalone_func(*a, **kw):
>       return func(*(a + p.args), **p.kwargs, **kw)

../../build/gradleenv/-1720702907/lib/python3.10/site-packages/parameterized/parameterized.py:620: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
apache_beam/io/external/xlang_jdbcio_it_test.py:220: in test_xlang_jdbc_write_read
    p

@Abacn
Copy link
Contributor Author

Abacn commented Mar 6, 2024

It's close to release cut so revert the change and investigate later

@Abacn
Copy link
Contributor Author

Abacn commented Mar 6, 2024

R: @jrmccluskey @damccorm

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Mar 6, 2024

PreCommit Python failed unrelated change and fixed by #30540, merging for now

@Abacn Abacn merged commit 2a10971 into master Mar 6, 2024
57 of 71 checks passed
@Abacn Abacn deleted the revert-30417-feature/add-jdbc-python-query-overwrite-test branch March 6, 2024 17:07
@Abacn Abacn mentioned this pull request Mar 6, 2024
3 tasks
MelodyShen pushed a commit to MelodyShen/beam that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants