BOOKKEEPER-1084: Make variables finale if necessary #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not all logger in bookkeeper & hedwig are static. some class like PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so this task is to make logger as a static variable if it didn't. with benefit, cleaning up the imports when touching that file. RB_ID=141138
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Jan 26, 2018
Descriptions of the changes in this PR: - add InterfaceAudience and InterfaceStability for public API to inform people what changes would be expected for those interface. - avoid using guava classes in public API since we will provide a shaded jar for distributedlog-core - enable ImportOrder checkstyle rule in some modules - move `org.apache.distributedlog.io` to `distributedlog-common` module - rename `setReadyToFlush` to `flush` and rename `flushAndSync` to `commit` for the new API Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None>, Leigh Stewart <None> This closes apache#172 from sijie/finalize_api, closes apache#166
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Jan 26, 2018
Descriptions of the changes in this PR: - add InterfaceAudience and InterfaceStability for public API to inform people what changes would be expected for those interface. - avoid using guava classes in public API since we will provide a shaded jar for distributedlog-core - enable ImportOrder checkstyle rule in some modules - move `org.apache.distributedlog.io` to `distributedlog-common` module - rename `setReadyToFlush` to `flush` and rename `flushAndSync` to `commit` for the new API Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None>, Leigh Stewart <None> This closes apache#172 from sijie/finalize_api, closes apache#166
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Jan 26, 2018
Descriptions of the changes in this PR: - add InterfaceAudience and InterfaceStability for public API to inform people what changes would be expected for those interface. - avoid using guava classes in public API since we will provide a shaded jar for distributedlog-core - enable ImportOrder checkstyle rule in some modules - move `org.apache.distributedlog.io` to `distributedlog-common` module - rename `setReadyToFlush` to `flush` and rename `flushAndSync` to `commit` for the new API Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None>, Leigh Stewart <None> This closes apache#172 from sijie/finalize_api, closes apache#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not all logger in bookkeeper & hedwig are static. some class like PendnigReadOp and LedgerEntry would have lots of objects, it might be bad. so this task is to make logger as a static variable if it didn't.
with benefit, cleaning up the imports when touching that file.
RB_ID=141138