BOOKKEEPER-1084: Make variables finale if necessary

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerEntry.java

@@ -1,5 +1,3 @@
-package org.apache.bookkeeper.client;
-
 /*
  *
  * Licensed to the Apache Software Foundation (ASF) under one
@@ -20,6 +18,7 @@
  * under the License.
  *
  */
+package org.apache.bookkeeper.client;
 
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.ByteBufInputStream;
@@ -31,7 +30,6 @@
  * the entry content.
  *
  */
-
 public class LedgerEntry {
     long ledgerId;
     long entryId;

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java

@@ -54,7 +54,7 @@
  *
  */
 class PendingReadOp implements Enumeration<LedgerEntry>, ReadEntryCallback {
-    private final static Logger LOG = LoggerFactory.getLogger(PendingReadOp.class);
+    private static final Logger LOG = LoggerFactory.getLogger(PendingReadOp.class);
 
     final int speculativeReadTimeout;
     final private ScheduledExecutorService scheduler;

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java

@@ -88,7 +88,6 @@
 import org.apache.bookkeeper.proto.BookkeeperProtocol.StatusCode;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.WriteLacRequest;
 import org.apache.bookkeeper.proto.BookkeeperProtocol.WriteLacResponse;
-
 import org.apache.bookkeeper.stats.NullStatsLogger;
 import org.apache.bookkeeper.stats.OpStatsLogger;
 import org.apache.bookkeeper.stats.StatsLogger;

bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerInputStream.java

@@ -33,7 +33,7 @@
 
 public class LedgerInputStream extends InputStream {
     private final static Logger LOG = LoggerFactory.getLogger(LedgerInputStream.class);
-    private LedgerHandle lh;
+    private final LedgerHandle lh;
     private ByteBuffer bytebuff;
     byte[] bbytes;
     long lastEntry = 0;

bookkeeper-server/src/main/java/org/apache/bookkeeper/streaming/LedgerOutputStream.java

@@ -37,7 +37,7 @@
  */
 public class LedgerOutputStream extends OutputStream {
     private final static Logger LOG = LoggerFactory.getLogger(LedgerOutputStream.class);
-    private LedgerHandle lh;
+    private final LedgerHandle lh;
     private ByteBuffer bytebuff;
     byte[] bbytes;
     int defaultSize = 1024 * 1024; // 1MB default size

bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LoopbackClient.java

@@ -39,13 +39,11 @@
 
 /**
  * This class tests BookieClient. It just sends the a new entry to itself.
- *
- *
- *
  */
-
 class LoopbackClient implements WriteCallback {
-    private final static Logger LOG = LoggerFactory.getLogger(LoopbackClient.class);
+
+    private static final Logger LOG = LoggerFactory.getLogger(LoopbackClient.class);
+
     BookieClient client;
     static int recvTimeout = 2000;
     long begin = 0;
@@ -81,6 +79,7 @@ void write(long ledgerId, long entry, byte[] data, BookieSocketAddress addr, Wri
         client.addEntry(addr, ledgerId, passwd, entry, Unpooled.wrappedBuffer(data), cb, ctx, BookieProtocol.FLAG_NONE);
     }
 
+    @Override
     public void writeComplete(int rc, long ledgerId, long entryId, BookieSocketAddress addr, Object ctx) {
         Counter counter = (Counter) ctx;
         counter.increment();