Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Dockerfile from centos to ubuntu #3483

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

shoothzj
Copy link
Member

Motivation

centos is not maintained anymore, switch to ubuntu

Changes

  • migrate from centos to ubuntu
  • use python3 instead of python2
  • Bump bookkeeper version from 4.12.1 to latest 4.15.1

@shoothzj
Copy link
Member Author

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good !

+1

@eolivelli eolivelli merged commit ef89ff2 into apache:master Sep 13, 2022
@shoothzj shoothzj deleted the migrate-to-ubuntu branch September 13, 2022 06:24
@zymap zymap added this to the 4.16.0 milestone Sep 14, 2022
@zymap
Copy link
Member

zymap commented Sep 14, 2022

I think we need to make the docker file changes apply to other branches.

@lhotari
Copy link
Member

lhotari commented Sep 14, 2022

Putting compilers in a production docker image isn't usually recommended. There shouldn't be any need to add gcc and g++.

See apache/pulsar#14093 . When installing python3 and pip3, the way to prevent installing compilers is to use apt-get -y install --no-install-recommends python3 python3-pip for the installation.

Blog post which explains the need to use --no-install-recommends when creating docker images: https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends

@shoothzj can you look into eliminating gcc/g++ from the docker image?

Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants