Remove development packages from Pulsar's docker images #14093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
sijie,
tuteng,
eolivelli and
michaeljmarshall
shoothzj
approved these changes
Feb 2, 2022
lhotari
force-pushed
the
lh-remove-dev-packages
branch
from
c4b64ee to
f47b7cb
Compare
|
For reference, I was wondering why we had these dependencies in the first place. It looks like they were needed because at one point we were building python from source: #4754. We don't do that now, so we definitely don't need these dependencies. |
|
Note that the |
merlimat
reviewed
Feb 2, 2022
|
@merlimat I pushed changes to omit installing GCC when python3-pip package gets installed. Let's see if the build and tests continue to pass. |
merlimat
approved these changes
Feb 2, 2022
|
Just adding a link to a blog post which explains the need to use |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
* Remove development packages from Pulsar's docker images * Add "--no-install-recommends" to skip installing GCC and lots of other tools * Install ca-certificates * Install build-essential for building pulsar-functions-go examples
lhotari
referenced
this pull request
in apache/bookkeeper
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14092
Motivation
There's a lot of unnecessary tooling that gets installed in the Pulsar docker images.
Modifications