[fix] fix Auditor ignoring bookies shut down before Auditor start #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlg99
changed the title
dlg99
changed the title
dlg99
changed the title
shoothzj
approved these changes
Jun 5, 2024
shoothzj
pushed a commit
that referenced
this pull request
Jun 8, 2024
) (cherry picked from commit 896137d)
lhotari
pushed a commit
that referenced
this pull request
Jun 13, 2024
) (cherry picked from commit 896137d)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Fix #4411
Fix #4410
Motivation
BookieAutoRecoveryTest is flaky on the CI
Changes
I cannot reproduce the test failures/timeouts locally, even by running the test in the loop 100+ times.
After experimenting with a few changes and running this on CI the fix is:
Making sure that Auditor start with all bookies in the knownBookies list, not just running ones, thus fixing situation when bookie goes down before Auditor startup completes.