Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] fix Auditor ignoring bookies shut down before Auditor start #4419

Merged
merged 3 commits into from
Jun 5, 2024
Merged

[fix] fix Auditor ignoring bookies shut down before Auditor start #4419

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
427e9a7
another attempt
dlg99 Jun 4, 2024
3ad0897
Another approach: make sure Auditor starts with all bookies, not just…
dlg99 Jun 5, 2024
e29e4e5
checkstyle
dlg99 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.BiConsumer;
import java.util.stream.Collectors;
import org.apache.bookkeeper.client.BKException;
import org.apache.bookkeeper.client.BookKeeper;
import org.apache.bookkeeper.client.BookKeeperAdmin;
Expand Down Expand Up @@ -386,7 +387,12 @@ public void start() {

try {
watchBookieChanges();
knownBookies = getAvailableBookies();
// Start with all available bookies
// to handle situations where the auditor
// is started after some bookies have already failed
knownBookies = admin.getAllBookies().stream()
.map(BookieId::toString)
.collect(Collectors.toList());
this.ledgerUnderreplicationManager
.notifyLostBookieRecoveryDelayChanged(new LostBookieRecoveryDelayChangedCb());
} catch (BKException bke) {
Expand Down