Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt #199

Closed
wants to merge 3 commits into from

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 28, 2023

Platforms affected

n/a

Motivation and Context

use latest npm glob dependency.

Description

  • bump glob to 9.0.1
  • updated code to use glob.globSync, not glob.sync.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added enhancement dependencies Pull requests that update a dependency file labels Feb 28, 2023
@erisu erisu added this to the 5.0.0 milestone Feb 28, 2023
@erisu erisu requested a review from dpogue February 28, 2023 02:58
@erisu erisu marked this pull request as draft February 28, 2023 03:16
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #199 (e2f25fa) into master (ecad4db) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          20       20           
  Lines        1144     1144           
=======================================
  Hits         1011     1011           
  Misses        133      133           
Impacted Files Coverage Δ
src/ConfigChanges/ConfigFile.js 92.23% <100.00%> (ø)
src/PluginInfo/PluginInfoProvider.js 79.31% <100.00%> (ø)
src/superspawn.js 85.24% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erisu erisu modified the milestones: 5.0.0, 6.0.0 Feb 28, 2023
@erisu
Copy link
Member Author

erisu commented Feb 28, 2023

Unable to reproduce the failing tests on my Windows 10 Pro environment.

I changed the status of this PR to draft and set its milestone for 6.0.0. More investigation is required.

@erisu erisu changed the title dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt [RFC] dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt Mar 9, 2023
@dpogue dpogue closed this in #203 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants