Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Modernize some dependencies #203

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Mar 24, 2024

Platforms affected

All

Motivation and Context

Bring some dependencies up to date and remove some dependencies that aren't needed with modern NodeJS APIs.

closes #199

Description

  • Replace uses of fs-extra with built-in NodeJS fs APIs
  • Replace glob with fast-glob so that we don't have both dependencies in the project
  • Dropped some lodash dependencies that have built-in replacements

Testing

Unit tests pass.

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.40%. Comparing base (dd3eca8) to head (bc5f84f).
Report is 1 commits behind head on master.

Files Patch % Lines
src/ConfigParser/ConfigParser.js 50.00% 1 Missing ⚠️
src/superspawn.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   88.37%   88.40%   +0.03%     
==========================================
  Files          20       20              
  Lines        1144     1147       +3     
==========================================
+ Hits         1011     1014       +3     
  Misses        133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpogue dpogue force-pushed the deps-202403 branch 2 times, most recently from 96ec760 to 2dd352e Compare March 24, 2024 08:15
@dpogue dpogue marked this pull request as ready for review March 24, 2024 08:17
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Changes LGTM

@erisu
Copy link
Member

erisu commented Mar 24, 2024

Might want to rebuild the package-lock.json file once.

It appears the following packages are still listed in the lock file:

    "fs-extra": "^11.1.0",
    "glob": "^7.1.6",

@dpogue
Copy link
Member Author

dpogue commented Mar 24, 2024

Might want to rebuild the package-lock.json file once.

Oops, good catch. I've regenerated package-lock.json

@dpogue dpogue marked this pull request as draft March 25, 2024 06:09
@dpogue dpogue marked this pull request as ready for review March 27, 2024 16:16
@dpogue dpogue merged commit 12135bd into apache:master Mar 27, 2024
10 checks passed
@dpogue dpogue deleted the deps-202403 branch March 27, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants