-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Modernize some dependencies #203
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 88.37% 88.40% +0.03%
==========================================
Files 20 20
Lines 1144 1147 +3
==========================================
+ Hits 1011 1014 +3
Misses 133 133 ☔ View full report in Codecov by Sentry. |
96ec760
to
2dd352e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Changes LGTM
Might want to rebuild the It appears the following packages are still listed in the lock file: "fs-extra": "^11.1.0",
"glob": "^7.1.6", |
Oops, good catch. I've regenerated package-lock.json |
Platforms affected
All
Motivation and Context
Bring some dependencies up to date and remove some dependencies that aren't needed with modern NodeJS APIs.
closes #199
Description
fs-extra
with built-in NodeJSfs
APIsglob
withfast-glob
so that we don't have both dependencies in the projectTesting
Unit tests pass.
Checklist