Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Jasmine@~3.1.0 #37

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Pin Jasmine@~3.1.0 #37

merged 1 commit into from
Aug 16, 2018

Conversation

erisu
Copy link
Member

@erisu erisu commented Aug 15, 2018

Platforms affected

common (test)

What does this PR do?

This PR fixes the recent test failures on master branch.

These tests are failing because of the latest Jasmine@3.2.0 that has been released within the past 2 days. (https://github.com/jasmine/jasmine-npm/releases/tag/v3.2.0)

By pinning Jasmine@3.1.0 in package.json, the tests will continue to pass.

🚀 Jasmine@^3.2 Investigation and support will be handled in ticket: apache/cordova-ios#393 (depending on outcome, a separate ticket mat be required for each affect repo.)

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #37   +/-   ##
======================================
  Coverage    85.9%   85.9%           
======================================
  Files          19      19           
  Lines        1738    1738           
  Branches      361     361           
======================================
  Hits         1493    1493           
  Misses        245     245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2dca1c...49fa7c4. Read the comment docs.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu erisu merged commit d3a8dee into apache:master Aug 16, 2018
@erisu erisu deleted the jasmine-pin-fix branch April 4, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants