Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
common (test)
What does this PR do?
This PR fixes the recent test failures on master branch.
These tests are failing because of the latest Jasmine@3.2.0 that has been released within the past 2 days. (https://github.com/jasmine/jasmine-npm/releases/tag/v3.2.0)
By pinning Jasmine@3.1.0 in package.json, the tests will continue to pass.
🚀 Jasmine@^3.2 Investigation and support will be handled in ticket: apache/cordova-ios#393 (depending on outcome, a separate ticket mat be required for each affect repo.)
What testing has been done on this change?
Failed with version up: https://travis-ci.org/cordova-develop/cordova-common/builds/416211005
Fix with version pin: https://travis-ci.org/cordova-develop/cordova-common/builds/416215969
Checklist