Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate & Fix Test with Jasmine@^3.2.0 #393

Closed
erisu opened this issue Aug 10, 2018 · 0 comments · Fixed by #632
Closed

Investigate & Fix Test with Jasmine@^3.2.0 #393

erisu opened this issue Aug 10, 2018 · 0 comments · Fixed by #632
Labels
bug

Comments

@erisu
Copy link
Member

erisu commented Aug 10, 2018 •
edited
Loading

Overview

With the recent release of jasmine@3.2.0, two of the tests have begun to fail.

The Goal

  • Investigate if the test failures are caused by our tests or a bug introduced by Jasmine.
  • If the issue is caused by our tests, the tests should be updated to work with jasmine@3.2.0.

Error Log

Suite error: Platform Api .prototype addPlugin
  Message:
    TypeError: plugin.getFrameworks is not a function
  Stack:
        at <Jasmine>
        at /Users/travis/build/apache/cordova-ios/bin/templates/scripts/cordova/Api.js:106:414
        at _fulfilled (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:854:54)
        at /Users/travis/build/apache/cordova-ios/node_modules/q/q.js:883:30
        at Promise.promise.promiseDispatch (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:816:13)
        at /Users/travis/build/apache/cordova-ios/node_modules/q/q.js:877:14
        at runSingle (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:137:13)
        at flush (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:125:13)
        at process._tickCallback (internal/process/next_tick.js:61:11)
Suite error: cordova/lib/list-devices run method
  Message:
    TypeError: Cannot read property 'forEach' of undefined
  Stack:
        at <Jasmine>
        at /Users/travis/build/apache/cordova-ios/bin/templates/scripts/cordova/lib/list-devices:40:17
        at _fulfilled (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:854:54)
        at /Users/travis/build/apache/cordova-ios/node_modules/q/q.js:883:30
        at Promise.promise.promiseDispatch (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:816:13)
        at /Users/travis/build/apache/cordova-ios/node_modules/q/q.js:877:14
        at runSingle (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:137:13)
        at flush (/Users/travis/build/apache/cordova-ios/node_modules/q/q.js:125:13)
        at process._tickCallback (internal/process/next_tick.js:61:11)

Recent Reported Issues

Below is a list of reported issues with jasmine@3.2.0. These can be used to identify if our test issues are related.
raphinesse added a commit to raphinesse/cordova-lib that referenced this issue Aug 15, 2018
@raphinesse
Rollback jasmine to 3.1 to work around Promise issues
003ccc2 
See apache/cordova-ios#393
See jasmine/jasmine#1590
raphinesse added a commit to raphinesse/cordova-lib that referenced this issue Aug 15, 2018
@raphinesse
Pin Jasmine to 3.1 to work around Promise issues
2b65469 
See apache/cordova-ios#393
See jasmine/jasmine#1590
@raphinesse raphinesse mentioned this issue Aug 15, 2018
Merged
raphinesse added a commit to apache/cordova-lib that referenced this issue Aug 15, 2018
@raphinesse
Pin Jasmine to 3.1 to work around Promise issues (#639)
429438e 
A change in Jasmine 3.2 seems to be responsible for the recent CI failures. Pinning it to 3.1 for now.

See apache/cordova-ios#393,
See jasmine/jasmine#1590
See #636
@erisu erisu mentioned this issue Aug 15, 2018
Merged
3 tasks
@erisu erisu mentioned this issue Jun 18, 2019
Merged
@raphinesse raphinesse mentioned this issue Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update jasmine & fix broken tests raphinesse/cordova-ios
1 participant
@erisu