Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35 license header fixes (old branch) #34

Closed
wants to merge 3 commits into from

Conversation

brodycj
Copy link

@brodycj brodycj commented Aug 6, 2018

Resolves GH-35 (migrated from https://issues.apache.org/jira/browse/CB-14256):

  • dos2unix spec/support/dummy-local-plugin/plugin.xml
  • add license header to spec/support/dummy-local-plugin/plugin.xml (copied from cordova-plugin-device)
  • .ratignore cover artifacts in spec/support/repo-name-neq-plugin-id.git

needed for coho audit-license-headers -r fetch to pass ref: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test

should be merged by rebase or merge commit

Christopher J. Brody added 3 commits August 6, 2018 15:51
spec/support/dummy-local-plugin/plugin.xml

copied from cordova-plugin-device
.ratignore cover artifacts in spec/support/repo-name-neq-plugin-id.git
brodycj pushed a commit to brodycj/cordova-fetch that referenced this pull request Aug 6, 2018
brodycj pushed a commit to brodycj/cordova-fetch that referenced this pull request Aug 6, 2018
spec/support/dummy-local-plugin/plugin.xml

copied from cordova-plugin-device
@brodycj brodycj changed the title CB-14256 license header fixes GH-35 license header fixes Aug 6, 2018
@brodycj
Copy link
Author

brodycj commented Aug 6, 2018

To be raised in another PR with GH-35 in commit messages, no more "cb-14256-" branch name

@brodycj brodycj closed this Aug 6, 2018
@brodycj brodycj deleted the cb-14256-license-header-fix branch August 6, 2018 21:22
@brodycj brodycj changed the title GH-35 license header fixes GH-35 license header fixes (old branch) Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant