Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coho audit-license-headers issues in cordova-fetch #35

Closed
brodycj opened this issue Aug 6, 2018 · 4 comments · Fixed by #36
Closed

coho audit-license-headers issues in cordova-fetch #35

brodycj opened this issue Aug 6, 2018 · 4 comments · Fixed by #36
Assignees
Labels

Comments

@brodycj
Copy link

brodycj commented Aug 6, 2018

Migrated from https://issues.apache.org/jira/browse/CB-14256:

coho audit-license-headers -r fetch uncovered the following text files without a valid license header:

  • spec/support/dummy-local-plugin/plugin.xml
  • spec/support/repo-name-neq-plugin-id.git/HEAD
  • spec/support/repo-name-neq-plugin-id.git/config
  • spec/support/repo-name-neq-plugin-id.git/refs/heads/master

On the 1.3.x branch this issue only shows up in spec/support/dummy-local-plugin/plugin.xml at this time.

Recommended solution is to add standard header to spec/support/dummy-local-plugin/plugin.xml and add the other files to .ratignore.

@brodycj brodycj added the bug label Aug 6, 2018
@brodycj brodycj self-assigned this Aug 6, 2018
brodycj pushed a commit to brodycj/cordova-fetch that referenced this issue Aug 6, 2018
spec/support/dummy-local-plugin/plugin.xml

(copied from cordova-plugin-device)
brodycj pushed a commit to brodycj/cordova-fetch that referenced this issue Aug 6, 2018
.ratignore cover artifacts in spec/support/repo-name-neq-plugin-id.git
@raphinesse
Copy link
Contributor

I always wondered what these .ratignore files were doing. A quick search only told me that it was used by some Apache software. Could you enlighten me @brodybits? So that hopefully, next time I know which new files to add to it.

@brodycj
Copy link
Author

brodycj commented Aug 6, 2018

One of the steps to making a release according to cordova-coho docs is to do coho audit-license-headers, which uses the Apache "rat" tool to check that all text files have an appropriate license header. I discovered the .ratignore file can be used to ignore certain files, which seems to be mostly used for JSON files but I think should also be used for ".git" artifacts like were added in 36ecb8c (GH-24). It seems like this step is normally taken during the release process.

@brodycj
Copy link
Author

brodycj commented Aug 6, 2018

P.S. If anyone has a chance to quickly review PR #36 I would really appreciate it. I would like to get part of #36 into the upcoming patch release (GH-37) asap.

@raphinesse
Copy link
Contributor

I see. Thank you very much for the insights!

brodycj pushed a commit to brodycj/cordova-fetch that referenced this issue Aug 6, 2018
to ignore artifacts in spec/support/repo-name-neq-plugin-id.git
brodycj pushed a commit that referenced this issue Aug 6, 2018
spec/support/dummy-local-plugin/plugin.xml

(copied from cordova-plugin-device)
brodycj pushed a commit that referenced this issue Aug 6, 2018
to ignore artifacts in spec/support/repo-name-neq-plugin-id.git
brodycj pushed a commit to brodycj/cordova-fetch that referenced this issue Aug 6, 2018
spec/support/dummy-local-plugin/plugin.xml

(copied from cordova-plugin-device)
brodycj pushed a commit to brodycj/cordova-fetch that referenced this issue Aug 14, 2018
spec/support/dummy-local-plugin/plugin.xml

(copied from cordova-plugin-device)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants