Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35 license header fixes #36

Merged
merged 3 commits into from
Aug 6, 2018

Conversation

brodycj
Copy link

@brodycj brodycj commented Aug 6, 2018

Proposed changes to resolve GH-35:

  • dos2unix spec/support/dummy-local-plugin/plugin.xml
  • add license header to spec/support/dummy-local-plugin/plugin.xml (copied from cordova-plugin-device)
  • .ratignore cover artifacts in spec/support/repo-name-neq-plugin-id.git

These changes are needed for coho audit-license-headers -r fetch to pass ref: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test

Merging: should be merged by rebase or merge commit

Christopher J. Brody added 2 commits August 6, 2018 15:51
spec/support/dummy-local-plugin/plugin.xml

(copied from cordova-plugin-device)
@brodycj brodycj requested review from raphinesse and erisu August 6, 2018 21:33
brodycj referenced this pull request Aug 6, 2018
.ratignore cover artifacts in spec/support/repo-name-neq-plugin-id.git
to ignore artifacts in spec/support/repo-name-neq-plugin-id.git
@brodycj brodycj force-pushed the gh-35-license-header-fixes branch from ed14f04 to ca9b66e Compare August 6, 2018 22:35
@brodycj
Copy link
Author

brodycj commented Aug 6, 2018

Approved by @raphinesse in ed14f04#commitcomment-29979429, merging.

@brodycj brodycj merged commit 47d2c19 into apache:master Aug 6, 2018
@brodycj brodycj deleted the gh-35-license-header-fixes branch August 6, 2018 22:42
@brodycj brodycj removed the request for review from erisu August 6, 2018 22:44
brodycj pushed a commit to brodycj/cordova-fetch that referenced this pull request Aug 6, 2018
brodycj pushed a commit to brodycj/cordova-fetch that referenced this pull request Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coho audit-license-headers issues in cordova-fetch
1 participant