fix: replace variables in Podfile #752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodycj
reviewed
Dec 18, 2019
| @@ -406,10 +407,11 @@ Api.prototype.addPodSpecs = function (plugin, podSpecs, frameworkPods) { | |||
| events.emit('warn', '"framework" tag with type "podspec" is deprecated and will be removed. Please use the "podspec" tag.'); | |||
| events.emit('verbose', 'Adding pods since the plugin contained <framework>(s) with type="podspec"'); | |||
| frameworkPods.forEach(function (obj) { | |||
| var spec = obj.spec.includes('$') ? installOptions.variables[obj.spec.replace('$', '')] : obj.spec; | |||
There was a problem hiding this comment.
This looks like repeated code. I wonder if we could factor this out somehow?
5 tasks
|
replaced with #754 since this had conflicts and was missing the uninstall case, also followed the recommendation of reuse a function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #721
Platforms affected
ios
Motivation and Context
see #721
Description
replaces variables with the variable value
Testing
plugin for testing with variables in both podspec and framework
https://github.com/jcesarmobile/cordova-plugin-firebase-dynamiclinks
Checklist
(platform)if this change only applies to one platform (e.g.(android))