Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace variables in Podfile #754

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

jcesarmobile
Copy link
Member

Motivation and Context

replaces #752

closes #721

Description

replaces variables with the variable value

Testing

plugin for testing with variables in both podspec and framework
https://github.com/jcesarmobile/cordova-plugin-firebase-dynamiclinks

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #754 into master will increase coverage by 0.04%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   74.25%   74.29%   +0.04%     
==========================================
  Files          11       11              
  Lines        1845     1852       +7     
==========================================
+ Hits         1370     1376       +6     
- Misses        475      476       +1
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 70.58% <90.9%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb8f69...2e341a1. Read the comment docs.

@jcesarmobile jcesarmobile requested a review from erisu December 19, 2019 23:16
Copy link
Contributor

@knight9999 knight9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable specified in podspec pods are not getting replaced
4 participants