refactor: superspawn usage

[erisu]

Motivation and Context

Cleanup & use only superspawn everywhere.

Description

• Replace child_process with superspawn
• Remove direct requirement of Q dependency from cordova-ios
• Keep using Q.progress which is available with superspawn.

Testing

• npm t

Checklist

• I've run the tests to see all new and existing tests pass

[raphinesse]

Beside my code comments, there's two remarks I would like to make:

Command printing was dropped without replacement and without a note in the PR description. I think we need either one.

Do we need to transform execa Errors to a format compatible to the old one (child_process or superspawn)? Did you check if there is any error handling that relies on special error properties or anything like that?

[codecov-io]

Codecov Report

Merging #763 into master will decrease coverage by 0.22%.
The diff coverage is 57.64%.

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   74.20%   73.98%   -0.23%     
==========================================
  Files          13       13              
  Lines        1849     1791      -58     
==========================================
- Hits         1372     1325      -47     
+ Misses        477      466      -11     

Impacted Files	Coverage Δ
bin/templates/scripts/cordova/lib/Podfile.js	73.80% <14.28%> (+0.22%)	⬆️
bin/templates/scripts/cordova/lib/run.js	21.10% <14.28%> (-0.33%)	⬇️
bin/templates/scripts/cordova/lib/check_reqs.js	51.94% <37.50%> (ø)
bin/templates/scripts/cordova/lib/build.js	50.51% <66.66%> (-0.26%)	⬇️
bin/templates/scripts/cordova/lib/prepare.js	82.05% <66.66%> (ø)
bin/templates/scripts/cordova/Api.js	71.32% <100.00%> (-0.11%)	⬇️
bin/templates/scripts/cordova/lib/listDevices.js	100.00% <100.00%> (ø)
...emplates/scripts/cordova/lib/listEmulatorImages.js	100.00% <100.00%> (ø)
bin/templates/scripts/cordova/lib/versions.js	100.00% <100.00%> (+9.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65d685...17499fb. Read the comment docs.

[raphinesse]

With the commits I just pushed we have resolved everything except for these two remarks I left before:

Command printing was dropped without replacement and without a note in the PR description. I think we need either one.

Do we need to transform execa Errors to a format compatible to the old one (child_process or superspawn)? Did you check if there is any error handling that relies on special error properties or anything like that?

[erisu]

I will review everything again before answering.

It seems other changes will be needed anyways and more tests. I noticed that with the lack of tests it didn't catch something that would have become an issues after dependency changes.

Depending on timing, I am expecting maybe by late-Jan or early-Feb before I can answer and have all the fixes and new tests completed.

IF others need to push on with the major release, I recommend ignoring this PR for now and will target next next major.

[raphinesse]

This PR should probably renamed to "drop Q" or something like it

[erisu]

@raphinesse PR has been finalized and ready to review.

• Everything will use superspawn.
• cordova-ios direct requirement for Q dependency has been removed.
• Q.progress will remain to be used and accessible by superspawn.

needs a re-review

[erisu]

PR no longer valid. Replaced with #859 & #860