Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: drop q dependency #860

Merged
merged 2 commits into from
May 27, 2020
Merged

breaking: drop q dependency #860

merged 2 commits into from
May 27, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 20, 2020

Motivation, Context & Description

  • Remove direct requirement of Q dependency from cordova-ios
  • Keep the Q.progress calls which is available from superspawn.
  • Use Native Promises

Requires PR #851 & #859

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 20, 2020
@erisu erisu requested a review from timbru31 May 20, 2020 07:00
@erisu erisu mentioned this pull request May 20, 2020
1 task
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #860 into master will decrease coverage by 0.06%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   74.52%   74.46%   -0.07%     
==========================================
  Files          13       13              
  Lines        1680     1676       -4     
==========================================
- Hits         1252     1248       -4     
  Misses        428      428              
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/run.js 19.62% <0.00%> (-0.75%) ⬇️
bin/templates/scripts/cordova/lib/Podfile.js 73.20% <33.33%> (-0.13%) ⬇️
bin/templates/scripts/cordova/lib/check_reqs.js 46.93% <66.66%> (ø)
bin/templates/scripts/cordova/lib/prepare.js 85.67% <66.66%> (ø)
bin/templates/scripts/cordova/lib/build.js 50.25% <71.42%> (-0.26%) ⬇️
bin/templates/scripts/cordova/Api.js 71.53% <100.00%> (+0.10%) ⬆️
...emplates/scripts/cordova/lib/listEmulatorImages.js 100.00% <100.00%> (ø)
bin/templates/scripts/cordova/lib/versions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26d8b1...e73ad74. Read the comment docs.

bin/lib/utils.js Outdated Show resolved Hide resolved
bin/templates/scripts/cordova/Api.js Show resolved Hide resolved
bin/templates/scripts/cordova/Api.js Show resolved Hide resolved
@breautek
Copy link
Contributor

Also note that I ignored anything related to the prerequisite PRs.

@erisu erisu force-pushed the breaking/drop-q branch from 9f2fbbb to db95264 Compare May 27, 2020 04:36
@erisu erisu force-pushed the breaking/drop-q branch from db95264 to 9e7a562 Compare May 27, 2020 04:39
@erisu erisu requested a review from breautek May 27, 2020 04:45
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 094f826 into apache:master May 27, 2020
@erisu erisu deleted the breaking/drop-q branch May 27, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants