Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ios) Add InAppBrowserStatusBarStyle preference #765

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

mrbberra
Copy link
Contributor

Platforms affected

iOS

Motivation and Context

This allows apps that set a dark status bar background color using cordova-plugin-statusbar to set the status bar style when using the in app browser. Became necessary after GH-656.
Fixes: #728

Description

Adds the ability to set <preference name="InAppBrowserStatusBarStyle" value="lightcontent" /> in the config.xml file, so that the preferredStatusBarStyle becomes UIStatusBarStyleLightContent instead of UIStatusBarStyleDefault.

Testing

I created a test app and tried setting the InAppBrowserStatusBarStyle to "default", "lightcontent", and removing it alltogether. I didn't add any new automatic tests- not sure how.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@mrbberra mrbberra changed the title (ios) Add InAppBrowserStatusBarStyle preference #728 (ios) Add InAppBrowserStatusBarStyle preference Aug 19, 2020
dpa99c pushed a commit to dpa99c/cordova-plugin-inappbrowser-popup-bridge that referenced this pull request Sep 1, 2020
dpa99c pushed a commit to dpa99c/cordova-plugin-inappbrowser-test that referenced this pull request Sep 1, 2020
@dpa99c
Copy link
Contributor

dpa99c commented Sep 1, 2020

I've tested this with my test harness project and confirm it works as intended.

@dpa99c dpa99c merged commit 043f96a into apache:master Sep 1, 2020
@mosabab
Copy link
Contributor

mosabab commented Sep 1, 2020

I've tested this with my test harness project and confirm it works as intended.

Thanks for test and merges.

Does anyone add this <preference name="InAppBrowserStatusBarStyle" value="lightcontent" /> to config.xml (https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/index.md) documents ?

If not, i will add a pull request to explain this in general Config.xml Docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Set StatusBarStyle from config.xml
3 participants