Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec cleanup #20

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Spec cleanup #20

merged 5 commits into from
Oct 30, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Oct 30, 2019 •
edited
Loading

Motivation and Context

General test code cleanup. No changes in test coverage intended.

Addresses apache/cordova#169

Description

  • Let Jasmine handle promises
  • Don't use done for sync tests
  • Get fresh test subject beforeEach test
  • DRY regItemPattern tests
  • Wrap regItemPattern tests in common describe block

@raphinesse raphinesse requested a review from erisu October 30, 2019 08:02
@raphinesse raphinesse mentioned this pull request Oct 30, 2019
Closed
17 tasks
@raphinesse raphinesse merged commit 32ea9f2 into apache:master Oct 30, 2019
@raphinesse raphinesse deleted the spec-cleanup branch October 30, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

@breautek breautek Awaiting requested review from breautek

@timbru31 timbru31 Awaiting requested review from timbru31

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphinesse @erisu