Let Jasmine handle promises in tests

[raphinesse]

Almost all asynchronous interfaces we provide or work with, make use of Promises. Jasmine has elegant built-in support for handling promises. Nonetheless, most asynchronous legacy tests don't make use of it. Instead, they are using makeshift and often buggy constructs using Jasmine's callback-style asynchronous tests (using the done parameter).

In many repos the transition to a simpler more robust Promise handling in tests has already been made. This issue should serve as a checklist of the remaining work in this area.

It's also often helpful to make this transition before removing Q (#7) in the given repo.

Of course, there are perfectly acceptable usages of done, most notably when working with callback-based async interfaces. But these are the vast minority in our tests.

Task list

(only repos that feature or featured usage of done)

Tools/libs

• cordova-cli
• cordova-lib
• cordova-create
• cordova-fetch
• cordova-common
• cordova-js (acceptable usage)
• cordova-serve

Platforms

• cordova-android
• cordova-browser
• cordova-ios
• cordova-windows

Plugins

• cordova-plugin-battery-status (acceptable usage)
• cordova-plugin-file (acceptable usage)
• cordova-plugin-geolocation (acceptable usage)
• cordova-plugin-inappbrowser (acceptable usage)
• cordova-plugin-media (acceptable usage)
• cordova-plugin-screen-orientation

[raphinesse]

For future reference. You can find all usage of Jasmine's done with the following ESLint config:

rules:
    no-restricted-syntax:
        - error
        - selector: 'CallExpression[callee.name=it] > :function:nth-child(2) > :first-child'
          message: "Jasmine's done is not allowed"