You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
build.yml needs to be updated macos builds now that macos-latest is ARM64. Also
To prevent the sand from shifting under our feet in the future, we should switch to explicit macos versions for the different builds.
macos-14 for building arm64
macos-13 for building x86_64
Explanation
I yanked this from the PR. It contains way more detail than necessary because I didn't realize that the macos-runner changed.
dist-macos-aarch64.zip and dist-macos-latest.zip contain different files with the same name
Looking at the workflow file, build-macos-aarch does set --target aarch64-apple-darwin and that does result in a different file, but maturin seemingly ignores the target flag when it names the file.
In both the prior workflow and in this PR, the end result is that dist.zip would contain only one of the two wheels.
Follow on from #829
Change Required
build.yml
needs to be updatedmacos
builds now that macos-latest is ARM64. AlsoTo prevent the sand from shifting under our feet in the future, we should switch to explicit macos versions for the different builds.
macos-14
for buildingarm64
macos-13
for buildingx86_64
Explanation
I yanked this from the PR. It contains way more detail than necessary because I didn't realize that the
macos-runner
changed.dist-macos-aarch64.zip
anddist-macos-latest.zip
contain different files with the same nameLooking at the workflow file,
build-macos-aarch
does set--target aarch64-apple-darwin
and that does result in a different file, butmaturin
seemingly ignores the target flag when it names the file.In both the prior workflow and in this PR, the end result is that
dist.zip
would contain only one of the two wheels.Same file name
Different file contents
Looking at the docs, it looks like the names for the two macos wheels used to be different.
datafusion-python/dev/release/README.md
Lines 122 to 130 in 805183b
The text was updated successfully, but these errors were encountered: