Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): use proper mac runners #841

Merged
merged 3 commits into from
Sep 2, 2024
Merged

build(ci): use proper mac runners #841

merged 3 commits into from
Sep 2, 2024

Conversation

Michael-J-Ward
Copy link
Contributor

@Michael-J-Ward Michael-J-Ward commented Aug 26, 2024 •
edited
Loading

Which issue does this PR close?

Closes #831

Rationale for this change

GH updated the runner images.

macos-14 is now ARM64.
macos-13 is last x86_64.

What changes are included in this PR?

The build steps for mac have been updated.

This fix means we actually get a build wheel for x86_64 on macos.

Example the dist.zip this build:

unzip -- -l dist.zip
Archive:  dist.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
 17180608  08-26-2024 21:49   datafusion-40.0.0-cp38-abi3-macosx_10_12_x86_64.whl
 15600059  08-26-2024 21:49   datafusion-40.0.0-cp38-abi3-macosx_11_0_arm64.whl
 19048084  08-26-2024 21:49   datafusion-40.0.0-cp38-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
 18111348  08-26-2024 21:49   datafusion-40.0.0-cp38-abi3-manylinux_2_28_aarch64.whl
 18464214  08-26-2024 21:49   datafusion-40.0.0-cp38-abi3-win_amd64.whl
---------                     -------
 88404313                     5 files

Are there any user-facing changes?

No.

@Michael-J-Ward
build(ci): use proper mac runners
4893fe6 
GH updated the runner images.

macos-14 is now ARM64.
macos-13 is last x86_64.

Closes apache#831
@Michael-J-Ward Michael-J-Ward marked this pull request as ready for review August 27, 2024 14:49
andygrove
andygrove approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michael-J-Ward

@andygrove andygrove merged commit e8ebc4f into apache:main Sep 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update GH Build workflow now that macos-latest is ARM64
2 participants
@Michael-J-Ward @andygrove