Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: statically link xz2 #9311

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Conversation

universalmind303
Copy link
Contributor

Which issue does this PR close?

closes #9256

Rationale for this change

What changes are included in this PR?

Are these changes tested?

before:

> otool -L ./target/debug/datafusion-cli | grep 'liblzma'
        /usr/local/lib/liblzma.5.dylib (compatibility version 10.0.0, current version 10.5.0)

after:

> otool -L ./target/debug/datafusion-cli | grep 'liblzma'       
 # empty

Are there any user-facing changes?

users no longer need to dynamically link to liblzma or manually statically link

@github-actions github-actions bot added the core Core DataFusion crate label Feb 21, 2024
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it on Linux. Looks good to me!

@Dandandan Dandandan merged commit 73c08b5 into apache:main Feb 24, 2024
24 checks passed
@Dandandan
Copy link
Contributor

Thanks @universalmind303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature flag to statically link liblzma
3 participants