Consolidate Schema and RecordBatch projection #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/cleanups2
branch
from
479d018
to
20ec828
Compare
alamb
force-pushed
the
alamb/cleanups2
branch
from
20ec828
to
e48cf37
Compare
houqp
approved these changes
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1643, so draft until that is mergedWhich issue does this PR close?
Closes #1646
Rationale for this change
@hntd187 added
RecordBatch::projectandSchema::projectin apache/arrow-rs#1033, which among other thing correctly handle metadata and they make the code cleanerWhat changes are included in this PR?
Use
RecordBatch::projectandSchema::projectrather than duplicating the code (as well as missing metadata)Are there any user-facing changes?
N/A (maybe fewer bugs related to metadata missing)