-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl ops::Not
for expr
#763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one looks good -- it seems to have gotten lost in the shuffle / list of PRs. Sorry about that @jimexist
datafusion/src/logical_plan/expr.rs
Outdated
($TYPE:ty, $SCALAR:ident) => { | ||
#[allow(missing_docs)] | ||
($TYPE:ty, $SCALAR:ident, $DOC: expr) => { | ||
#[doc = $DOC] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
python/src/functions.rs
Outdated
@@ -20,7 +20,7 @@ use crate::udf; | |||
use crate::{expression, types::PyDataType}; | |||
use datafusion::arrow::datatypes::DataType; | |||
use datafusion::logical_plan; | |||
use pyo3::{prelude::*, wrap_pyfunction}; | |||
use pyo3::{prelude::*, types::PyTuple, wrap_pyfunction}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes to python intended for this PR @jimexist ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, let me rebase.
Which issue does this PR close?
Closes #.
Rationale for this change
Impl
ops::Not
forexpr
to make it more genericWhat changes are included in this PR?
Are there any user-facing changes?