ftr: Grpc Protocol Support #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop into feature/grpc
feat(grpc): 支持client grpc 调用
Codecov Report
@@ Coverage Diff @@
## develop #311 +/- ##
===========================================
+ Coverage 66.58% 66.85% +0.27%
===========================================
Files 113 118 +5
Lines 7239 7467 +228
===========================================
+ Hits 4820 4992 +172
- Misses 1947 1977 +30
- Partials 472 498 +26
Continue to review full report at Codecov.
|
Merge develop into feature/grpc and resolve conflicts
|
Perfect. LGTM |
hxmhlt
reviewed
Jan 11, 2020
remoting/zookeeper/listener.go
Outdated
| @@ -239,6 +241,7 @@ func (l *ZkEventListener) listenDirEvent(zkPath string, listener remoting.DataLi | |||
|
|
|||
| //listen sub path recursive | |||
| go func(zkPath string, listener remoting.DataListener) { | |||
| fmt.Printf("zkpath: %v \n", zkPath) | |||
| l.listenDirEvent(zkPath, listener) | |||
protocol/protocol.go
Outdated
| @@ -29,7 +29,7 @@ import ( | |||
| // Extension - protocol | |||
| type Protocol interface { | |||
| Export(invoker Invoker) Exporter | |||
| Refer(url common.URL) Invoker | |||
| Refer(url common.URL, impl interface{}) Invoker | |||
| Destroy() | |||
There was a problem hiding this comment.
Is there any other solution rather than add a parameter? Too many code changed..
And it's also not commonly used except for grpc.
Mod: modidfy Refer params and add licence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Merge the feature/grpc into develop
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: