Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move count down to final part to avoid meaningless waiting when exception throw #8406

Merged
merged 3 commits into from
Aug 5, 2021

Conversation

tonymarz
Copy link
Contributor

@tonymarz tonymarz commented Aug 3, 2021

What is the purpose of the change

move count down to final part to avoid meaningless waiting when exception throw

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #8406 (db80bff) into 3.0 (bb94723) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8406      +/-   ##
============================================
- Coverage     63.20%   63.16%   -0.05%     
- Complexity      311      312       +1     
============================================
  Files          1099     1099              
  Lines         46057    46057              
  Branches       6955     6955              
============================================
- Hits          29112    29093      -19     
- Misses        13693    13712      +19     
  Partials       3252     3252              
Impacted Files Coverage Δ
...gistry/client/migration/MigrationRuleListener.java 72.27% <100.00%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0.00%> (-5.27%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.47% <0.00%> (-4.39%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 64.40% <0.00%> (-3.39%) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 61.06% <0.00%> (-2.66%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 76.59% <0.00%> (-2.13%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.10% <0.00%> (-1.46%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 72.61% <0.00%> (-1.20%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 67.48% <0.00%> (-0.99%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb94723...db80bff. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 78d9012 into apache:3.0 Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants