Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull #1

Merged
merged 23 commits into from
Aug 3, 2021
Merged

pull #1

merged 23 commits into from
Aug 3, 2021

Conversation

tonymarz
Copy link
Owner

@tonymarz tonymarz commented Aug 3, 2021

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

pinxiong and others added 23 commits July 21, 2021 15:58
* Adjust the modifier of DynamicParamTable#init method

* Put the call to the getParameters() method outside the loop
Co-authored-by: fred.h <fred.h@binance.com>
* Nacos notify ServiceInstancesChangedEvent

* use log println error
* Dependencies Upgrade

* fix ut

* update nacos version

* remove eclipse-collections dependency

* fix compile error

* revert 401c56e

* exclude guava

* fix test compile
* Add the lost annotation of the Subclass of Protocol.

* rollback the class generate in native.
1. Use SPI to load ServiceListener
2. Check if MetadataService exported successfully
3. Check if ServiceConfig exported successfully
* Compatible with nacos grouping via group

* move nacos.group to dubbo.registry.nacos module
1. Make the exception more explicit
2. Threw RepException instead of logging
Fix a flaky test.

Clean shared state pollution to avoid flaky tests.
@tonymarz tonymarz merged commit db80bff into tonymarz:3.0 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants