forked from apache/dubbo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull #1
Merged
Merged
pull #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust the modifier of DynamicParamTable#init method * Put the call to the getParameters() method outside the loop
Co-authored-by: fred.h <fred.h@binance.com>
* Nacos notify ServiceInstancesChangedEvent * use log println error
* Dependencies Upgrade * fix ut * update nacos version * remove eclipse-collections dependency * fix compile error * revert 401c56e * exclude guava * fix test compile
* Add the lost annotation of the Subclass of Protocol. * rollback the class generate in native.
1. Use SPI to load ServiceListener 2. Check if MetadataService exported successfully 3. Check if ServiceConfig exported successfully
* Compatible with nacos grouping via group * move nacos.group to dubbo.registry.nacos module
1. Make the exception more explicit 2. Threw RepException instead of logging
Fix a flaky test. Clean shared state pollution to avoid flaky tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief changelog
Verifying this change
Checklist