-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33302] Allow to customize jdk version for connectors #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snuyanzin Can you add a test so that it also tests a run with Java 17?
@MartijnVisser thanks for the feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thanks!
The PR allows to customize jdk versions
At the same time it still keeps 8 and 1 as default fullback option
An example of connector with this
https://github.com/snuyanzin/flink-connector-opensearch/actions/runs/6560306886/job/17817647898
where 1.16.x, 1.17.x are running with 8 and 11 and 1.18.x with 8, 11, 17
the failure of the connector is related to connector's code which still doesn't support jdk17