Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33302] Allow to customize jdk version for connectors #24

Merged
merged 9 commits into from
Dec 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,13 @@ jobs:
with:
flink_version: 1.16-SNAPSHOT
connector_branch: ci_utils
flink118-java17-version:
uses: ./.github/workflows/ci.yml
with:
flink_version: 1.18.0
jdk_version: 17
connector_branch: ci_utils
run_dependency_convergence: false
disable-convergence:
uses: ./.github/workflows/ci.yml
with:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ on:
description: "Flink version to test against."
required: true
type: string
jdk_version:
description: "Jdk version to test against."
required: false
default: 8, 11
type: string
cache_flink_binary:
description: "Whether to cache the Flink binary. If not set this parameter is inferred from the version parameter. Must be set if 'flink_url' is used."
required: false
Expand Down Expand Up @@ -56,7 +61,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
jdk: [8, 11]
jdk: ${{ fromJSON(format('[{0}]', inputs.jdk_version)) }}
timeout-minutes: ${{ inputs.timeout_global }}
env:
MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=${{ inputs.flink_version }}
Expand Down
Loading