-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-29436][build] Upgrade spotless for running on JDK 17 #20911
Conversation
Could there be a bug in that spotless version that the skip parameter is being ignored? |
@zentol with this change I tested JDK 17 can work with spotless: gh pr checkout 20911
mvn -nsu spotless:apply ... while it generates diff on:
And I pushed a second commit for the change. |
Signed-off-by: tison <wander4096@gmail.com>
It seems the version bump cause this configure not work, I will try to find a reasonable followup: <!-- disable spotless since we need copy hive code -->
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin> Related issue: diffplug/spotless#1227 |
Signed-off-by: tison <wander4096@gmail.com>
This reverts commit 16c03fb.
Pushed a workaround on the plugin configs. I'm submitting a patch for upstream to avoid such a workaround. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 % CI passing
@zentol thanks for your reviewing. I've submitted a patch to the upstream diffplug/spotless#1353. Supposed 1) we're not in a hurry on this change 2) it is not easily to conflict with other patches 3) upstream uses auto-release after a patch is merged. I suggest after CI passes we wait a few days (e.g., after the Chinese National Day holiday I'll come back on Oct. 8th) to try to eliminate the workaround in this patch. |
Sure, let's wait for the release. |
Signed-off-by: tison <wander4096@gmail.com>
Upgrade to 2.27.1 and eliminate the workaround. Wait for the new CI report and merge. |
@flinkbot run azure |
Although test fails should be unrelated, IIRC someone said you should get CI passed to merge a patch, lol. Rerun. |
This blocker is fixed by: diffplug/spotless#1224 and diffplug/spotless#1228.