-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: maven plugin should identify skip config key #1353
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Confirm this patch works locally. @bbarker-eb you can help with testing this patch by building a local snapshot follow these instructions. @jherico I don't know the issue about "ratchetFrom" or something. You can test that this patch doesn't cause regression. @nedtwigg please help with reviewing. I hope this patch is a trivial fix to merge. Updating CHANGES file now... |
Signed-off-by: tison <wander4096@gmail.com>
Thanks a lot @tisonkun! I'm ready to merge and release as soon as I get one "works for me" from someone. |
I'm trying to walk through the reproduce process. |
This PR works for me on my local machine. |
Thanks very much to @tisonkun for the fix and everyone else for the testing confirmation! Released in |
Thank you for this fix!
|
CHANGES updates will be pushed later. I trigger the CI tasks first.