Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support to compat the old layered memtable options #1568

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Sep 14, 2024

Rationale

We introduce the explicit flag to control should we enable layered memtable, but it has some compatibility problem when upgrading from old version.
This pr add an option to support compating the old layered memtable on/off control method.

Detailed Changes

Add an option to support compating the old layered memtable on/off control method.

Test Plan

Manually.

@Rachelint Rachelint changed the title Support compat to the old layered memtable options Support to compat the old layered memtable options Sep 14, 2024
@Rachelint Rachelint changed the title Support to compat the old layered memtable options chore: support to compat the old layered memtable options Sep 14, 2024
@github-actions github-actions bot added the chore label Sep 14, 2024
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 changed the title chore: support to compat the old layered memtable options fix: support to compat the old layered memtable options Sep 14, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 14, 2024
@jiacai2050 jiacai2050 merged commit 3bcc64f into apache:main Sep 14, 2024
14 of 15 checks passed
@jiacai2050
Copy link
Contributor

2024-09-14 15:41:23.595 ERRO [src/components/panic_ext/src/lib.rs:57] thread 'main' panicked 'Failed to create catalog manager: BuildSysCatalog { sou
rce: OpenTable { source: OpenTableWithCause { msg: None, source: ReadMetaUpdate { table_id: TableId(1099511627777), source: Error(Other { source: fai
led to new table_data, space_id:1, table_name:sys_catalog                                                                                          
                                                                                            
Caused by:                                                                                                                        
    Found invalid table opts, msg:layered memtable is enabled but mutable_switch_threshold is 0.
    Backtrace:

When error above is thrown, try add following config:

[analytic]
try_compat_old_layered_memtable_opts = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants