Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backwards-compatible createSocket calls #536

Merged

Conversation

Sineaggi
Copy link

In order to allow for backwards-compatibility with projects that override/extend the existing plain and ssl connection factories, we'll specify the createSocket(Proxy, HttpContext) method to call the original createSocket method when proxy is null.

@ok2c ok2c merged commit a8db310 into apache:master Jan 16, 2024
9 checks passed
@ok2c
Copy link
Member

ok2c commented Jan 16, 2024

@Sineaggi Also cherry-picked to 5.3.x

@Sineaggi Sineaggi deleted the allow-backwards-compatible-createSocket branch January 16, 2024 21:19
@Sineaggi
Copy link
Author

@ok2c thanks!

@ok2c
Copy link
Member

ok2c commented Jan 20, 2024

@Sineaggi I intend to deprecate the entire ConnectionSocketFactory layer that goes back to the days of HttpClient v2 and harmonize the TLS setup logic of the classic transport with the async one, possibly by providing a single TLS strategy that works with both transports. If you are interested in reviewing or collaborating on the new APIs do let me know.

@arturobernalg
Copy link
Member

@Sineaggi I intend to deprecate the entire ConnectionSocketFactory layer that goes back to the days of HttpClient v2 and harmonize the TLS setup logic of the classic transport with the async one, possibly by providing a single TLS strategy that works with both transports. If you are interested in reviewing or collaborating on the new APIs do let me know.

@ok2c I'd be interested in collaborating on the new APIs and reviewing the harmonization of the TLS setup logic across transports.

@ok2c
Copy link
Member

ok2c commented Jan 21, 2024

@ok2c I'd be interested in collaborating on the new APIs and reviewing the harmonization of the TLS setup logic across transports.

@arturobernalg Sure. The proposed changes will go through the standard review process.

@ok2c
Copy link
Member

ok2c commented Jan 22, 2024

@Sineaggi Please see #540. Do feel free to let me know if you want anything done differently to ensure API compatibility with your specific application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants