Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS setup harmonization in the classic and async connection operators #540

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

ok2c
Copy link
Member

@ok2c ok2c commented Jan 22, 2024

  • Deprecation of ConnectionSocketFactory / LayeredConnectionSocketFactory APIs in favor of TlsSocketStrategy consistent with TlsStrategy used by the async APIs.
  • Deprecation of PlainConnectionSocketFactory without a direct replacement.
  • Deprecation of SSLConnectionSocketFactory in favor of DefaultClientTlsStrategy that can be used with classic and async transports

@ok2c
Copy link
Member Author

ok2c commented Jan 22, 2024

@arturobernalg Please take a look.

@ok2c
Copy link
Member Author

ok2c commented Jan 26, 2024

If I hear no objections I will merge this PR in the coming days.

Copy link
Member

@arturobernalg arturobernalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ok2c LGTM

@basil
Copy link

basil commented Oct 28, 2024

@ok2c Causes HTTPCLIENT-2348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants