Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add integration tests for rest catalog. #109

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

liurenjie1024
Copy link
Contributor

Close #100 .

@liurenjie1024
Copy link
Contributor Author

cc @Fokko @Xuanwo @ZENOTME @JanKaul PTAL

Makefile Outdated Show resolved Hide resolved
crates/catalog/rest/Cargo.toml Outdated Show resolved Hide resolved
@liurenjie1024 liurenjie1024 force-pushed the renjie/issue-100 branch 2 times, most recently from 4b919a4 to 53df4cb Compare December 4, 2023 07:19
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @liurenjie1024 ! Thanks for adding this, appreciate it!

Copy link
Contributor

@ZENOTME ZENOTME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM. Thanks!

crates/catalog/rest/src/catalog.rs Outdated Show resolved Hide resolved
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@liurenjie1024
Copy link
Contributor Author

cc @Fokko I've resolved conflicts.

@Fokko Fokko merged commit 641d058 into apache:main Dec 8, 2023
6 checks passed
shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
* test: Introduce integration test of rest catalog client against docker container

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Rest catalog integration test.
5 participants