Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Conversion between literal and json should depends on type. #120

Merged
merged 1 commit into from
Dec 19, 2023
Merged

refactor: Conversion between literal and json should depends on type. #120

merged 1 commit into from
Dec 19, 2023

Conversation

liurenjie1024
Copy link
Contributor

Close #117.

We removed type information stored in structs..

@liurenjie1024 liurenjie1024 requested review from JanKaul, Fokko and Xuanwo and removed request for JanKaul December 15, 2023 03:39
@liurenjie1024
Copy link
Contributor Author

cc @Xuanwo @JanKaul @Fokko @ZENOTME PTAL

Xuanwo
Xuanwo approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ZENOTME
ZENOTME approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ZENOTME ZENOTME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Fokko
Fokko approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @liurenjie1024

@Fokko Fokko merged commit d98c325 into apache:main Dec 19, 2023
6 checks passed
@liurenjie1024 liurenjie1024 deleted the renjie/issue-117 branch December 19, 2023 08:08
@liurenjie1024 liurenjie1024 mentioned this pull request Dec 19, 2023
Closed
shaeqahmed pushed a commit to matanolabs/iceberg-rust that referenced this pull request Dec 9, 2024
@liurenjie1024 @shaeqahmed
refactor: Conversion between literal and json should depends on type …
dcfc06e 
…information (apache#120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZENOTME ZENOTME ZENOTME approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@Fokko Fokko Fokko approved these changes

@JanKaul JanKaul Awaiting requested review from JanKaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Type when converting from Literal to JsonValue.
4 participants
@liurenjie1024 @Fokko @Xuanwo @ZENOTME